61f36020cd
When searching for users, page the results by default, and respect the
default paging limits.
This makes queries like '/api/v1/users/search?limit=1' actually work.
Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit 9b85f97835)
132 lines
3.8 KiB
Go
132 lines
3.8 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package integration
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
|
|
auth_model "code.gitea.io/gitea/models/auth"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
"code.gitea.io/gitea/modules/setting"
|
|
api "code.gitea.io/gitea/modules/structs"
|
|
"code.gitea.io/gitea/modules/test"
|
|
"code.gitea.io/gitea/tests"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
type SearchResults struct {
|
|
OK bool `json:"ok"`
|
|
Data []*api.User `json:"data"`
|
|
}
|
|
|
|
func TestAPIUserSearchLoggedIn(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
adminUsername := "user1"
|
|
session := loginUser(t, adminUsername)
|
|
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadUser)
|
|
query := "user2"
|
|
req := NewRequestf(t, "GET", "/api/v1/users/search?q=%s", query).
|
|
AddTokenAuth(token)
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
var results SearchResults
|
|
DecodeJSON(t, resp, &results)
|
|
assert.NotEmpty(t, results.Data)
|
|
for _, user := range results.Data {
|
|
assert.Contains(t, user.UserName, query)
|
|
assert.NotEmpty(t, user.Email)
|
|
}
|
|
}
|
|
|
|
func TestAPIUserSearchNotLoggedIn(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
query := "user2"
|
|
req := NewRequestf(t, "GET", "/api/v1/users/search?q=%s", query)
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
var results SearchResults
|
|
DecodeJSON(t, resp, &results)
|
|
assert.NotEmpty(t, results.Data)
|
|
var modelUser *user_model.User
|
|
for _, user := range results.Data {
|
|
assert.Contains(t, user.UserName, query)
|
|
modelUser = unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: user.ID})
|
|
assert.EqualValues(t, modelUser.GetPlaceholderEmail(), user.Email)
|
|
}
|
|
}
|
|
|
|
func TestAPIUserSearchPaged(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
defer test.MockVariableValue(&setting.API.DefaultPagingNum, 5)()
|
|
|
|
req := NewRequest(t, "GET", "/api/v1/users/search?limit=1")
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
var limitedResults SearchResults
|
|
DecodeJSON(t, resp, &limitedResults)
|
|
assert.Len(t, limitedResults.Data, 1)
|
|
|
|
req = NewRequest(t, "GET", "/api/v1/users/search")
|
|
resp = MakeRequest(t, req, http.StatusOK)
|
|
|
|
var results SearchResults
|
|
DecodeJSON(t, resp, &results)
|
|
assert.Len(t, results.Data, 5)
|
|
}
|
|
|
|
func TestAPIUserSearchSystemUsers(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
for _, systemUser := range []*user_model.User{
|
|
user_model.NewGhostUser(),
|
|
user_model.NewActionsUser(),
|
|
} {
|
|
t.Run(systemUser.Name, func(t *testing.T) {
|
|
req := NewRequestf(t, "GET", "/api/v1/users/search?uid=%d", systemUser.ID)
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
var results SearchResults
|
|
DecodeJSON(t, resp, &results)
|
|
assert.NotEmpty(t, results.Data)
|
|
if assert.EqualValues(t, 1, len(results.Data)) {
|
|
user := results.Data[0]
|
|
assert.EqualValues(t, user.UserName, systemUser.Name)
|
|
assert.EqualValues(t, user.ID, systemUser.ID)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestAPIUserSearchAdminLoggedInUserHidden(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
adminUsername := "user1"
|
|
session := loginUser(t, adminUsername)
|
|
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadUser)
|
|
query := "user31"
|
|
req := NewRequestf(t, "GET", "/api/v1/users/search?q=%s", query).
|
|
AddTokenAuth(token)
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
var results SearchResults
|
|
DecodeJSON(t, resp, &results)
|
|
assert.NotEmpty(t, results.Data)
|
|
for _, user := range results.Data {
|
|
assert.Contains(t, user.UserName, query)
|
|
assert.NotEmpty(t, user.Email)
|
|
assert.EqualValues(t, "private", user.Visibility)
|
|
}
|
|
}
|
|
|
|
func TestAPIUserSearchNotLoggedInUserHidden(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
query := "user31"
|
|
req := NewRequestf(t, "GET", "/api/v1/users/search?q=%s", query)
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
var results SearchResults
|
|
DecodeJSON(t, resp, &results)
|
|
assert.Empty(t, results.Data)
|
|
}
|