tom/forkjo
tom/forkjo
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions 1

Prevent double-close of issues (#6233)

Browse source
This commit is contained in:
zeripath 2019-03-05 02:52:52 +00:00 committed by techknowlogick
parent 19862699cd
commit f066bd2b3f
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
models/issue.go
View file

@ -699,8 +699,14 @@ func UpdateIssueCols(issue *Issue, cols ...string) error {
} }
func (issue *Issue) changeStatus(e *xorm.Session, doer *User, isClosed bool) (err error) { func (issue *Issue) changeStatus(e *xorm.Session, doer *User, isClosed bool) (err error) {
// Reload the issue
currentIssue, err := getIssueByID(e, issue.ID)
if err != nil {
return err
}
// Nothing should be performed if current status is same as target status // Nothing should be performed if current status is same as target status
if issue.IsClosed == isClosed { if currentIssue.IsClosed == isClosed {
return nil return nil
} }