tom/forkjo
tom/forkjo
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages 1 Wiki Activity Actions 1

Fix error logged when repos qs is empty (#9591)

Browse source 
* Fix error logged when repos qs is empty

* Update routers/user/home.go

Co-Authored-By: Lauris BH <lauris@nix.lv>

Co-authored-by: techknowlogick <matti@mdranta.net>
Co-authored-by: Lauris BH <lauris@nix.lv>
This commit is contained in:
guillep2k 2020-01-03 18:39:12 -03:00 committed by Lauris BH
parent 4a768e1c3e
commit bedd7b2833
1 changed files with 14 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
routers/user/home.go
View file

@ -389,21 +389,23 @@ func Issues(ctx *context.Context) {
reposQuery := ctx.Query("repos") reposQuery := ctx.Query("repos")
var repoIDs []int64 var repoIDs []int64
if issueReposQueryPattern.MatchString(reposQuery) { if len(reposQuery) != 0 {
// remove "[" and "]" from string if issueReposQueryPattern.MatchString(reposQuery) {
reposQuery = reposQuery[1 : len(reposQuery)-1] // remove "[" and "]" from string
//for each ID (delimiter ",") add to int to repoIDs reposQuery = reposQuery[1 : len(reposQuery)-1]
for _, rID := range strings.Split(reposQuery, ",") { //for each ID (delimiter ",") add to int to repoIDs
// Ensure nonempty string entries for _, rID := range strings.Split(reposQuery, ",") {
if rID != "" && rID != "0" { // Ensure nonempty string entries
rIDint64, err := strconv.ParseInt(rID, 10, 64) if rID != "" && rID != "0" {
if err == nil { rIDint64, err := strconv.ParseInt(rID, 10, 64)
repoIDs = append(repoIDs, rIDint64) if err == nil {
repoIDs = append(repoIDs, rIDint64)
}
} }
} }
} else {
log.Error("issueReposQueryPattern not match with query")
} }
} else {
log.Error("issueReposQueryPattern not match with query")
} }
isShowClosed := ctx.Query("state") == "closed" isShowClosed := ctx.Query("state") == "closed"