tom/forkjo
tom/forkjo
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions 1

bug: require.Eventually must not test with assert

Browse source 
Otherwise it fails the test instead of retrying if the condition fails
at least once.

(cherry picked from commit 2541a943ce)
This commit is contained in:
Earl Warren 2024-11-09 00:07:18 +01:00 committed by forgejo-backport-action
parent 3a4612cb2b
commit 8c51053739
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tests/integration/actions_trigger_test.go
View file

@ -321,7 +321,7 @@ jobs:
require.Eventually(t, func() bool { require.Eventually(t, func() bool {
actionRuns = make([]*actions_model.ActionRun, 0) actionRuns = make([]*actions_model.ActionRun, 0)
require.NoError(t, db.GetEngine(db.DefaultContext).Where("repo_id=?", baseRepo.ID).Find(&actionRuns)) require.NoError(t, db.GetEngine(db.DefaultContext).Where("repo_id=?", baseRepo.ID).Find(&actionRuns))
return assert.Len(t, actionRuns, count) return len(actionRuns) == count
}, 30*time.Second, 1*time.Second) }, 30*time.Second, 1*time.Second)
// verify the expected ActionRuns were created // verify the expected ActionRuns were created