tom/forkjo
tom/forkjo
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages 1 Wiki Activity Actions 1

Fix deadline on update issue or PR via API (#8696)

Browse source 
* Fix deadline on update issue or PR via API

* variable initialized directly (review comment)
This commit is contained in:
David Svantesson 2019-10-28 00:35:20 +01:00 committed by Lauris BH
parent 478f7db68e
commit 018b0e8180
2 changed files with 14 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
routers/api/v1/repo/issue.go
View file

@ -336,15 +336,14 @@ func EditIssue(ctx *context.APIContext, form api.EditIssueOption) {
} }
// Update the deadline // Update the deadline
var deadlineUnix timeutil.TimeStamp if form.Deadline != nil && ctx.Repo.CanWrite(models.UnitTypeIssues) {
if form.Deadline != nil && !form.Deadline.IsZero() && ctx.Repo.CanWrite(models.UnitTypeIssues) { deadlineUnix := timeutil.TimeStamp(form.Deadline.Unix())
deadlineUnix = timeutil.TimeStamp(form.Deadline.Unix())
}
if err := models.UpdateIssueDeadline(issue, deadlineUnix, ctx.User); err != nil { if err := models.UpdateIssueDeadline(issue, deadlineUnix, ctx.User); err != nil {
ctx.Error(500, "UpdateIssueDeadline", err) ctx.Error(500, "UpdateIssueDeadline", err)
return return
} }
issue.DeadlineUnix = deadlineUnix
}
// Add/delete assignees // Add/delete assignees

9
routers/api/v1/repo/pull.go
View file

@ -392,15 +392,14 @@ func EditPullRequest(ctx *context.APIContext, form api.EditPullRequestOption) {
} }
// Update Deadline // Update Deadline
var deadlineUnix timeutil.TimeStamp if form.Deadline != nil {
if form.Deadline != nil && !form.Deadline.IsZero() { deadlineUnix := timeutil.TimeStamp(form.Deadline.Unix())
deadlineUnix = timeutil.TimeStamp(form.Deadline.Unix())
}
if err := models.UpdateIssueDeadline(issue, deadlineUnix, ctx.User); err != nil { if err := models.UpdateIssueDeadline(issue, deadlineUnix, ctx.User); err != nil {
ctx.Error(500, "UpdateIssueDeadline", err) ctx.Error(500, "UpdateIssueDeadline", err)
return return
} }
issue.DeadlineUnix = deadlineUnix
}
// Add/delete assignees // Add/delete assignees