tom/forkjo - Forgejo: git.ar21.de

tom/forkjo

2 lines

115 B

Markdown

Raw Normal View History

[BUG] admin authentication source JS errors (#4059) While trying to understand #1236, I was quite confused not to see the `Use Custom URLs` checkbox. This checkbox disappeared in b95a893b22a (because `getElementById` does not expect a `#` as first char), fixed in 4e816e1326086ff0929c028f837f62ba1c747759. After solving this, switching from `Nextcloud` to `OpenID Connect` triggered a JS error, which is addressed in 3efa4d836a300dc45b3ffece766b2b13539fc47c. Manual testing: - go to http://localhost:3000/admin/auths - click on `Add authentication source` - Choose `Authentication type`: `OAuth2` - Choose `OAuth2 provider`: `Nextcloud` - check that the `Use Custom URLs Instead of Default URLs` checkbox toggles the fields below - let the checkbox be checked - Switch the `OAuth2 provider` to `OpenID Connect` - ensure that no JS error is shown - Switch the `OAuth2 provider` to `Mastodon` - check that the fields below `Use Custom URLs Instead of Default URLs` have the right defaults (mastodon.social) ![2024-06-07-101638.png](/attachments/5bd6692e-3457-4dd8-b1c1-50e9a95a3100) Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4059 Reviewed-by: twenty-panda <twenty-panda@noreply.codeberg.org> Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: oliverpool <git@olivier.pfad.fr> Co-committed-by: oliverpool <git@olivier.pfad.fr>

2024-06-17 12:05:59 +02:00

Wrongfully hidden "Use Custom URLs Instead of Default URLs" checkbox on Authentication Source Administration page.