sebleh/docker_exporter
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Reuse DockerClient for each probe, no need to dispose

Browse source
This commit is contained in:
Sander Saares 2019-12-24 09:07:37 +02:00
parent 50410e3cf0
commit 7226c7c3cc
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
DockerTracker.cs
View file

@ -22,6 +22,7 @@ namespace DockerExporter
public Uri DockerUrl { get; } public Uri DockerUrl { get; }
private readonly DockerClientConfiguration _clientConfiguration; private readonly DockerClientConfiguration _clientConfiguration;
private readonly DockerClient _client;
// If an execution can get the lock on first try, it will really perform the update. // If an execution can get the lock on first try, it will really perform the update.
// Otherwise, it will wait for the lock and then perform a no-op update to just leave // Otherwise, it will wait for the lock and then perform a no-op update to just leave
@ -35,6 +36,7 @@ namespace DockerExporter
// TODO: Support mutual authentication via certificates. // TODO: Support mutual authentication via certificates.
_clientConfiguration = new DockerClientConfiguration(dockerUrl, null, Constants.DockerCommandTimeout); _clientConfiguration = new DockerClientConfiguration(dockerUrl, null, Constants.DockerCommandTimeout);
_client = _clientConfiguration.CreateClient();
} }
/// <summary> /// <summary>
@ -65,15 +67,13 @@ namespace DockerExporter
using var probeDurationTimer = DockerTrackerMetrics.ProbeDuration.NewTimer(); using var probeDurationTimer = DockerTrackerMetrics.ProbeDuration.NewTimer();
using var client = _clientConfiguration.CreateClient();
IList<ContainerListResponse> allContainers; IList<ContainerListResponse> allContainers;
try try
{ {
using var listDurationTimer = DockerTrackerMetrics.ListContainersDuration.NewTimer(); using var listDurationTimer = DockerTrackerMetrics.ListContainersDuration.NewTimer();
allContainers = await client.Containers.ListContainersAsync(new ContainersListParameters allContainers = await _client.Containers.ListContainersAsync(new ContainersListParameters
{ {
All = true All = true
}, cts.Token); }, cts.Token);
@ -101,7 +101,7 @@ namespace DockerExporter
var updateTasks = new List<Task>(); var updateTasks = new List<Task>();
foreach (var tracker in _containerTrackers.Values) foreach (var tracker in _containerTrackers.Values)
updateTasks.Add(tracker.TryUpdateAsync(client, cts.Token)); updateTasks.Add(tracker.TryUpdateAsync(_client, cts.Token));
// Only exceptions from the update calls should be terminal exceptions, // Only exceptions from the update calls should be terminal exceptions,
// so it is fine not to catch anything that may be thrown here. // so it is fine not to catch anything that may be thrown here.