From 62ef4e961b2c042052c63b7446a23e54fc3dd0fd Mon Sep 17 00:00:00 2001
From: Olliver Schinagl <oliver@schinagl.nl>
Date: Mon, 29 May 2023 10:24:00 +0200
Subject: [PATCH] examples: Have cron container depend on the app container

The cron container requires the files created by the app container, to
start its cron tasks. There is a potential race condition here, where
cron starts to run before the app container is even up, before the app
container has populated `/var/www/html`. This is undesired and easily
solved by making sure cron depends on the app container.

Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
---
 .../docker-compose/insecure/mariadb/apache/docker-compose.yml    | 1 +
 .examples/docker-compose/insecure/mariadb/fpm/docker-compose.yml | 1 +
 .../docker-compose/insecure/postgres/apache/docker-compose.yml   | 1 +
 .../docker-compose/insecure/postgres/fpm/docker-compose.yml      | 1 +
 .../with-nginx-proxy/mariadb/apache/docker-compose.yml           | 1 +
 .../with-nginx-proxy/mariadb/fpm/docker-compose.yml              | 1 +
 .../with-nginx-proxy/postgres/apache/docker-compose.yml          | 1 +
 .../with-nginx-proxy/postgres/fpm/docker-compose.yml             | 1 +
 8 files changed, 8 insertions(+)

diff --git a/.examples/docker-compose/insecure/mariadb/apache/docker-compose.yml b/.examples/docker-compose/insecure/mariadb/apache/docker-compose.yml
index 11ff5bf9..a9bb99c2 100644
--- a/.examples/docker-compose/insecure/mariadb/apache/docker-compose.yml
+++ b/.examples/docker-compose/insecure/mariadb/apache/docker-compose.yml
@@ -41,6 +41,7 @@ services:
       - nextcloud:/var/www/html:z
     entrypoint: /cron.sh
     depends_on:
+      - app
       - db
       - redis
 
diff --git a/.examples/docker-compose/insecure/mariadb/fpm/docker-compose.yml b/.examples/docker-compose/insecure/mariadb/fpm/docker-compose.yml
index 1da64182..d9e35ee1 100644
--- a/.examples/docker-compose/insecure/mariadb/fpm/docker-compose.yml
+++ b/.examples/docker-compose/insecure/mariadb/fpm/docker-compose.yml
@@ -52,6 +52,7 @@ services:
       - nextcloud:/var/www/html:z
     entrypoint: /cron.sh
     depends_on:
+      - app
       - db
       - redis
 
diff --git a/.examples/docker-compose/insecure/postgres/apache/docker-compose.yml b/.examples/docker-compose/insecure/postgres/apache/docker-compose.yml
index 0a48bd05..d50d0296 100644
--- a/.examples/docker-compose/insecure/postgres/apache/docker-compose.yml
+++ b/.examples/docker-compose/insecure/postgres/apache/docker-compose.yml
@@ -36,6 +36,7 @@ services:
       - nextcloud:/var/www/html:z
     entrypoint: /cron.sh
     depends_on:
+      - app
       - db
       - redis
 
diff --git a/.examples/docker-compose/insecure/postgres/fpm/docker-compose.yml b/.examples/docker-compose/insecure/postgres/fpm/docker-compose.yml
index d4947d9f..3fb7864d 100644
--- a/.examples/docker-compose/insecure/postgres/fpm/docker-compose.yml
+++ b/.examples/docker-compose/insecure/postgres/fpm/docker-compose.yml
@@ -47,6 +47,7 @@ services:
       - nextcloud:/var/www/html:z
     entrypoint: /cron.sh
     depends_on:
+      - app
       - db
       - redis
 
diff --git a/.examples/docker-compose/with-nginx-proxy/mariadb/apache/docker-compose.yml b/.examples/docker-compose/with-nginx-proxy/mariadb/apache/docker-compose.yml
index 05e2c8b5..7e2abfc9 100644
--- a/.examples/docker-compose/with-nginx-proxy/mariadb/apache/docker-compose.yml
+++ b/.examples/docker-compose/with-nginx-proxy/mariadb/apache/docker-compose.yml
@@ -45,6 +45,7 @@ services:
       - nextcloud:/var/www/html:z
     entrypoint: /cron.sh
     depends_on:
+      - app
       - db
       - redis
 
diff --git a/.examples/docker-compose/with-nginx-proxy/mariadb/fpm/docker-compose.yml b/.examples/docker-compose/with-nginx-proxy/mariadb/fpm/docker-compose.yml
index 23088782..cfb8e031 100644
--- a/.examples/docker-compose/with-nginx-proxy/mariadb/fpm/docker-compose.yml
+++ b/.examples/docker-compose/with-nginx-proxy/mariadb/fpm/docker-compose.yml
@@ -57,6 +57,7 @@ services:
       - nextcloud:/var/www/html:z
     entrypoint: /cron.sh
     depends_on:
+      - app
       - db
       - redis
 
diff --git a/.examples/docker-compose/with-nginx-proxy/postgres/apache/docker-compose.yml b/.examples/docker-compose/with-nginx-proxy/postgres/apache/docker-compose.yml
index bcbeeb46..a8fcf1be 100644
--- a/.examples/docker-compose/with-nginx-proxy/postgres/apache/docker-compose.yml
+++ b/.examples/docker-compose/with-nginx-proxy/postgres/apache/docker-compose.yml
@@ -40,6 +40,7 @@ services:
       - nextcloud:/var/www/html:z
     entrypoint: /cron.sh
     depends_on:
+      - app
       - db
       - redis
 
diff --git a/.examples/docker-compose/with-nginx-proxy/postgres/fpm/docker-compose.yml b/.examples/docker-compose/with-nginx-proxy/postgres/fpm/docker-compose.yml
index 0ba28418..b7313875 100644
--- a/.examples/docker-compose/with-nginx-proxy/postgres/fpm/docker-compose.yml
+++ b/.examples/docker-compose/with-nginx-proxy/postgres/fpm/docker-compose.yml
@@ -52,6 +52,7 @@ services:
       - nextcloud:/var/www/html:z
     entrypoint: /cron.sh
     depends_on:
+      - app
       - db
       - redis