From 6df959975d2ba3d945acda4ee30215f74d212d8f Mon Sep 17 00:00:00 2001 From: Sebastian Neuser Date: Tue, 17 Jun 2025 14:08:56 +0200 Subject: [PATCH 1/3] chore(entrypoint): Fix whitespace issues Signed-off-by: Sebastian Neuser --- 29/apache/entrypoint.sh | 12 ++++++------ 29/fpm-alpine/entrypoint.sh | 12 ++++++------ 29/fpm/entrypoint.sh | 12 ++++++------ 30/apache/entrypoint.sh | 12 ++++++------ 30/fpm-alpine/entrypoint.sh | 12 ++++++------ 30/fpm/entrypoint.sh | 12 ++++++------ 31/apache/entrypoint.sh | 12 ++++++------ 31/fpm-alpine/entrypoint.sh | 12 ++++++------ 31/fpm/entrypoint.sh | 12 ++++++------ docker-entrypoint.sh | 12 ++++++------ 10 files changed, 60 insertions(+), 60 deletions(-) diff --git a/29/apache/entrypoint.sh b/29/apache/entrypoint.sh index e3b88f14..3bb57f1f 100755 --- a/29/apache/entrypoint.sh +++ b/29/apache/entrypoint.sh @@ -240,7 +240,7 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP echo "Starting nextcloud installation" max_retries=10 try=0 - until [ "$try" -gt "$max_retries" ] || run_as "php /var/www/html/occ maintenance:install $install_options" + until [ "$try" -gt "$max_retries" ] || run_as "php /var/www/html/occ maintenance:install $install_options" do echo "Retrying install..." try=$((try+1)) @@ -252,21 +252,21 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP fi if [ -n "${NEXTCLOUD_TRUSTED_DOMAINS+x}" ]; then echo "Setting trusted domains…" - set -f # turn off glob + set -f # turn off glob NC_TRUSTED_DOMAIN_IDX=1 for DOMAIN in ${NEXTCLOUD_TRUSTED_DOMAINS}; do DOMAIN=$(echo "${DOMAIN}" | sed -e 's/^[[:space:]]*//' -e 's/[[:space:]]*$//') run_as "php /var/www/html/occ config:system:set trusted_domains $NC_TRUSTED_DOMAIN_IDX --value=\"${DOMAIN}\"" NC_TRUSTED_DOMAIN_IDX=$((NC_TRUSTED_DOMAIN_IDX+1)) done - set +f # turn glob back on + set +f # turn glob back on fi run_path post-installation - fi + fi fi - # not enough specified to do a fully automated installation - if [ "$install" = false ]; then + # not enough specified to do a fully automated installation + if [ "$install" = false ]; then echo "Next step: Access your instance to finish the web-based installation!" echo "Hint: You can specify NEXTCLOUD_ADMIN_USER and NEXTCLOUD_ADMIN_PASSWORD and the database variables _prior to first launch_ to fully automate initial installation." fi diff --git a/29/fpm-alpine/entrypoint.sh b/29/fpm-alpine/entrypoint.sh index e3b88f14..3bb57f1f 100755 --- a/29/fpm-alpine/entrypoint.sh +++ b/29/fpm-alpine/entrypoint.sh @@ -240,7 +240,7 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP echo "Starting nextcloud installation" max_retries=10 try=0 - until [ "$try" -gt "$max_retries" ] || run_as "php /var/www/html/occ maintenance:install $install_options" + until [ "$try" -gt "$max_retries" ] || run_as "php /var/www/html/occ maintenance:install $install_options" do echo "Retrying install..." try=$((try+1)) @@ -252,21 +252,21 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP fi if [ -n "${NEXTCLOUD_TRUSTED_DOMAINS+x}" ]; then echo "Setting trusted domains…" - set -f # turn off glob + set -f # turn off glob NC_TRUSTED_DOMAIN_IDX=1 for DOMAIN in ${NEXTCLOUD_TRUSTED_DOMAINS}; do DOMAIN=$(echo "${DOMAIN}" | sed -e 's/^[[:space:]]*//' -e 's/[[:space:]]*$//') run_as "php /var/www/html/occ config:system:set trusted_domains $NC_TRUSTED_DOMAIN_IDX --value=\"${DOMAIN}\"" NC_TRUSTED_DOMAIN_IDX=$((NC_TRUSTED_DOMAIN_IDX+1)) done - set +f # turn glob back on + set +f # turn glob back on fi run_path post-installation - fi + fi fi - # not enough specified to do a fully automated installation - if [ "$install" = false ]; then + # not enough specified to do a fully automated installation + if [ "$install" = false ]; then echo "Next step: Access your instance to finish the web-based installation!" echo "Hint: You can specify NEXTCLOUD_ADMIN_USER and NEXTCLOUD_ADMIN_PASSWORD and the database variables _prior to first launch_ to fully automate initial installation." fi diff --git a/29/fpm/entrypoint.sh b/29/fpm/entrypoint.sh index e3b88f14..3bb57f1f 100755 --- a/29/fpm/entrypoint.sh +++ b/29/fpm/entrypoint.sh @@ -240,7 +240,7 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP echo "Starting nextcloud installation" max_retries=10 try=0 - until [ "$try" -gt "$max_retries" ] || run_as "php /var/www/html/occ maintenance:install $install_options" + until [ "$try" -gt "$max_retries" ] || run_as "php /var/www/html/occ maintenance:install $install_options" do echo "Retrying install..." try=$((try+1)) @@ -252,21 +252,21 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP fi if [ -n "${NEXTCLOUD_TRUSTED_DOMAINS+x}" ]; then echo "Setting trusted domains…" - set -f # turn off glob + set -f # turn off glob NC_TRUSTED_DOMAIN_IDX=1 for DOMAIN in ${NEXTCLOUD_TRUSTED_DOMAINS}; do DOMAIN=$(echo "${DOMAIN}" | sed -e 's/^[[:space:]]*//' -e 's/[[:space:]]*$//') run_as "php /var/www/html/occ config:system:set trusted_domains $NC_TRUSTED_DOMAIN_IDX --value=\"${DOMAIN}\"" NC_TRUSTED_DOMAIN_IDX=$((NC_TRUSTED_DOMAIN_IDX+1)) done - set +f # turn glob back on + set +f # turn glob back on fi run_path post-installation - fi + fi fi - # not enough specified to do a fully automated installation - if [ "$install" = false ]; then + # not enough specified to do a fully automated installation + if [ "$install" = false ]; then echo "Next step: Access your instance to finish the web-based installation!" echo "Hint: You can specify NEXTCLOUD_ADMIN_USER and NEXTCLOUD_ADMIN_PASSWORD and the database variables _prior to first launch_ to fully automate initial installation." fi diff --git a/30/apache/entrypoint.sh b/30/apache/entrypoint.sh index e3b88f14..3bb57f1f 100755 --- a/30/apache/entrypoint.sh +++ b/30/apache/entrypoint.sh @@ -240,7 +240,7 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP echo "Starting nextcloud installation" max_retries=10 try=0 - until [ "$try" -gt "$max_retries" ] || run_as "php /var/www/html/occ maintenance:install $install_options" + until [ "$try" -gt "$max_retries" ] || run_as "php /var/www/html/occ maintenance:install $install_options" do echo "Retrying install..." try=$((try+1)) @@ -252,21 +252,21 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP fi if [ -n "${NEXTCLOUD_TRUSTED_DOMAINS+x}" ]; then echo "Setting trusted domains…" - set -f # turn off glob + set -f # turn off glob NC_TRUSTED_DOMAIN_IDX=1 for DOMAIN in ${NEXTCLOUD_TRUSTED_DOMAINS}; do DOMAIN=$(echo "${DOMAIN}" | sed -e 's/^[[:space:]]*//' -e 's/[[:space:]]*$//') run_as "php /var/www/html/occ config:system:set trusted_domains $NC_TRUSTED_DOMAIN_IDX --value=\"${DOMAIN}\"" NC_TRUSTED_DOMAIN_IDX=$((NC_TRUSTED_DOMAIN_IDX+1)) done - set +f # turn glob back on + set +f # turn glob back on fi run_path post-installation - fi + fi fi - # not enough specified to do a fully automated installation - if [ "$install" = false ]; then + # not enough specified to do a fully automated installation + if [ "$install" = false ]; then echo "Next step: Access your instance to finish the web-based installation!" echo "Hint: You can specify NEXTCLOUD_ADMIN_USER and NEXTCLOUD_ADMIN_PASSWORD and the database variables _prior to first launch_ to fully automate initial installation." fi diff --git a/30/fpm-alpine/entrypoint.sh b/30/fpm-alpine/entrypoint.sh index e3b88f14..3bb57f1f 100755 --- a/30/fpm-alpine/entrypoint.sh +++ b/30/fpm-alpine/entrypoint.sh @@ -240,7 +240,7 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP echo "Starting nextcloud installation" max_retries=10 try=0 - until [ "$try" -gt "$max_retries" ] || run_as "php /var/www/html/occ maintenance:install $install_options" + until [ "$try" -gt "$max_retries" ] || run_as "php /var/www/html/occ maintenance:install $install_options" do echo "Retrying install..." try=$((try+1)) @@ -252,21 +252,21 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP fi if [ -n "${NEXTCLOUD_TRUSTED_DOMAINS+x}" ]; then echo "Setting trusted domains…" - set -f # turn off glob + set -f # turn off glob NC_TRUSTED_DOMAIN_IDX=1 for DOMAIN in ${NEXTCLOUD_TRUSTED_DOMAINS}; do DOMAIN=$(echo "${DOMAIN}" | sed -e 's/^[[:space:]]*//' -e 's/[[:space:]]*$//') run_as "php /var/www/html/occ config:system:set trusted_domains $NC_TRUSTED_DOMAIN_IDX --value=\"${DOMAIN}\"" NC_TRUSTED_DOMAIN_IDX=$((NC_TRUSTED_DOMAIN_IDX+1)) done - set +f # turn glob back on + set +f # turn glob back on fi run_path post-installation - fi + fi fi - # not enough specified to do a fully automated installation - if [ "$install" = false ]; then + # not enough specified to do a fully automated installation + if [ "$install" = false ]; then echo "Next step: Access your instance to finish the web-based installation!" echo "Hint: You can specify NEXTCLOUD_ADMIN_USER and NEXTCLOUD_ADMIN_PASSWORD and the database variables _prior to first launch_ to fully automate initial installation." fi diff --git a/30/fpm/entrypoint.sh b/30/fpm/entrypoint.sh index e3b88f14..3bb57f1f 100755 --- a/30/fpm/entrypoint.sh +++ b/30/fpm/entrypoint.sh @@ -240,7 +240,7 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP echo "Starting nextcloud installation" max_retries=10 try=0 - until [ "$try" -gt "$max_retries" ] || run_as "php /var/www/html/occ maintenance:install $install_options" + until [ "$try" -gt "$max_retries" ] || run_as "php /var/www/html/occ maintenance:install $install_options" do echo "Retrying install..." try=$((try+1)) @@ -252,21 +252,21 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP fi if [ -n "${NEXTCLOUD_TRUSTED_DOMAINS+x}" ]; then echo "Setting trusted domains…" - set -f # turn off glob + set -f # turn off glob NC_TRUSTED_DOMAIN_IDX=1 for DOMAIN in ${NEXTCLOUD_TRUSTED_DOMAINS}; do DOMAIN=$(echo "${DOMAIN}" | sed -e 's/^[[:space:]]*//' -e 's/[[:space:]]*$//') run_as "php /var/www/html/occ config:system:set trusted_domains $NC_TRUSTED_DOMAIN_IDX --value=\"${DOMAIN}\"" NC_TRUSTED_DOMAIN_IDX=$((NC_TRUSTED_DOMAIN_IDX+1)) done - set +f # turn glob back on + set +f # turn glob back on fi run_path post-installation - fi + fi fi - # not enough specified to do a fully automated installation - if [ "$install" = false ]; then + # not enough specified to do a fully automated installation + if [ "$install" = false ]; then echo "Next step: Access your instance to finish the web-based installation!" echo "Hint: You can specify NEXTCLOUD_ADMIN_USER and NEXTCLOUD_ADMIN_PASSWORD and the database variables _prior to first launch_ to fully automate initial installation." fi diff --git a/31/apache/entrypoint.sh b/31/apache/entrypoint.sh index e3b88f14..3bb57f1f 100755 --- a/31/apache/entrypoint.sh +++ b/31/apache/entrypoint.sh @@ -240,7 +240,7 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP echo "Starting nextcloud installation" max_retries=10 try=0 - until [ "$try" -gt "$max_retries" ] || run_as "php /var/www/html/occ maintenance:install $install_options" + until [ "$try" -gt "$max_retries" ] || run_as "php /var/www/html/occ maintenance:install $install_options" do echo "Retrying install..." try=$((try+1)) @@ -252,21 +252,21 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP fi if [ -n "${NEXTCLOUD_TRUSTED_DOMAINS+x}" ]; then echo "Setting trusted domains…" - set -f # turn off glob + set -f # turn off glob NC_TRUSTED_DOMAIN_IDX=1 for DOMAIN in ${NEXTCLOUD_TRUSTED_DOMAINS}; do DOMAIN=$(echo "${DOMAIN}" | sed -e 's/^[[:space:]]*//' -e 's/[[:space:]]*$//') run_as "php /var/www/html/occ config:system:set trusted_domains $NC_TRUSTED_DOMAIN_IDX --value=\"${DOMAIN}\"" NC_TRUSTED_DOMAIN_IDX=$((NC_TRUSTED_DOMAIN_IDX+1)) done - set +f # turn glob back on + set +f # turn glob back on fi run_path post-installation - fi + fi fi - # not enough specified to do a fully automated installation - if [ "$install" = false ]; then + # not enough specified to do a fully automated installation + if [ "$install" = false ]; then echo "Next step: Access your instance to finish the web-based installation!" echo "Hint: You can specify NEXTCLOUD_ADMIN_USER and NEXTCLOUD_ADMIN_PASSWORD and the database variables _prior to first launch_ to fully automate initial installation." fi diff --git a/31/fpm-alpine/entrypoint.sh b/31/fpm-alpine/entrypoint.sh index e3b88f14..3bb57f1f 100755 --- a/31/fpm-alpine/entrypoint.sh +++ b/31/fpm-alpine/entrypoint.sh @@ -240,7 +240,7 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP echo "Starting nextcloud installation" max_retries=10 try=0 - until [ "$try" -gt "$max_retries" ] || run_as "php /var/www/html/occ maintenance:install $install_options" + until [ "$try" -gt "$max_retries" ] || run_as "php /var/www/html/occ maintenance:install $install_options" do echo "Retrying install..." try=$((try+1)) @@ -252,21 +252,21 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP fi if [ -n "${NEXTCLOUD_TRUSTED_DOMAINS+x}" ]; then echo "Setting trusted domains…" - set -f # turn off glob + set -f # turn off glob NC_TRUSTED_DOMAIN_IDX=1 for DOMAIN in ${NEXTCLOUD_TRUSTED_DOMAINS}; do DOMAIN=$(echo "${DOMAIN}" | sed -e 's/^[[:space:]]*//' -e 's/[[:space:]]*$//') run_as "php /var/www/html/occ config:system:set trusted_domains $NC_TRUSTED_DOMAIN_IDX --value=\"${DOMAIN}\"" NC_TRUSTED_DOMAIN_IDX=$((NC_TRUSTED_DOMAIN_IDX+1)) done - set +f # turn glob back on + set +f # turn glob back on fi run_path post-installation - fi + fi fi - # not enough specified to do a fully automated installation - if [ "$install" = false ]; then + # not enough specified to do a fully automated installation + if [ "$install" = false ]; then echo "Next step: Access your instance to finish the web-based installation!" echo "Hint: You can specify NEXTCLOUD_ADMIN_USER and NEXTCLOUD_ADMIN_PASSWORD and the database variables _prior to first launch_ to fully automate initial installation." fi diff --git a/31/fpm/entrypoint.sh b/31/fpm/entrypoint.sh index e3b88f14..3bb57f1f 100755 --- a/31/fpm/entrypoint.sh +++ b/31/fpm/entrypoint.sh @@ -240,7 +240,7 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP echo "Starting nextcloud installation" max_retries=10 try=0 - until [ "$try" -gt "$max_retries" ] || run_as "php /var/www/html/occ maintenance:install $install_options" + until [ "$try" -gt "$max_retries" ] || run_as "php /var/www/html/occ maintenance:install $install_options" do echo "Retrying install..." try=$((try+1)) @@ -252,21 +252,21 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP fi if [ -n "${NEXTCLOUD_TRUSTED_DOMAINS+x}" ]; then echo "Setting trusted domains…" - set -f # turn off glob + set -f # turn off glob NC_TRUSTED_DOMAIN_IDX=1 for DOMAIN in ${NEXTCLOUD_TRUSTED_DOMAINS}; do DOMAIN=$(echo "${DOMAIN}" | sed -e 's/^[[:space:]]*//' -e 's/[[:space:]]*$//') run_as "php /var/www/html/occ config:system:set trusted_domains $NC_TRUSTED_DOMAIN_IDX --value=\"${DOMAIN}\"" NC_TRUSTED_DOMAIN_IDX=$((NC_TRUSTED_DOMAIN_IDX+1)) done - set +f # turn glob back on + set +f # turn glob back on fi run_path post-installation - fi + fi fi - # not enough specified to do a fully automated installation - if [ "$install" = false ]; then + # not enough specified to do a fully automated installation + if [ "$install" = false ]; then echo "Next step: Access your instance to finish the web-based installation!" echo "Hint: You can specify NEXTCLOUD_ADMIN_USER and NEXTCLOUD_ADMIN_PASSWORD and the database variables _prior to first launch_ to fully automate initial installation." fi diff --git a/docker-entrypoint.sh b/docker-entrypoint.sh index e3b88f14..3bb57f1f 100755 --- a/docker-entrypoint.sh +++ b/docker-entrypoint.sh @@ -240,7 +240,7 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP echo "Starting nextcloud installation" max_retries=10 try=0 - until [ "$try" -gt "$max_retries" ] || run_as "php /var/www/html/occ maintenance:install $install_options" + until [ "$try" -gt "$max_retries" ] || run_as "php /var/www/html/occ maintenance:install $install_options" do echo "Retrying install..." try=$((try+1)) @@ -252,21 +252,21 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP fi if [ -n "${NEXTCLOUD_TRUSTED_DOMAINS+x}" ]; then echo "Setting trusted domains…" - set -f # turn off glob + set -f # turn off glob NC_TRUSTED_DOMAIN_IDX=1 for DOMAIN in ${NEXTCLOUD_TRUSTED_DOMAINS}; do DOMAIN=$(echo "${DOMAIN}" | sed -e 's/^[[:space:]]*//' -e 's/[[:space:]]*$//') run_as "php /var/www/html/occ config:system:set trusted_domains $NC_TRUSTED_DOMAIN_IDX --value=\"${DOMAIN}\"" NC_TRUSTED_DOMAIN_IDX=$((NC_TRUSTED_DOMAIN_IDX+1)) done - set +f # turn glob back on + set +f # turn glob back on fi run_path post-installation - fi + fi fi - # not enough specified to do a fully automated installation - if [ "$install" = false ]; then + # not enough specified to do a fully automated installation + if [ "$install" = false ]; then echo "Next step: Access your instance to finish the web-based installation!" echo "Hint: You can specify NEXTCLOUD_ADMIN_USER and NEXTCLOUD_ADMIN_PASSWORD and the database variables _prior to first launch_ to fully automate initial installation." fi From f3fce0fda2ed9b268adddb5f432e11f9a977a876 Mon Sep 17 00:00:00 2001 From: Sebastian Neuser Date: Tue, 17 Jun 2025 14:19:10 +0200 Subject: [PATCH 2/3] impr(entrypoint): Fix / disable shellcheck warnings Signed-off-by: Sebastian Neuser --- 29/apache/entrypoint.sh | 12 ++++++++---- 29/fpm-alpine/entrypoint.sh | 12 ++++++++---- 29/fpm/entrypoint.sh | 12 ++++++++---- 30/apache/entrypoint.sh | 12 ++++++++---- 30/fpm-alpine/entrypoint.sh | 12 ++++++++---- 30/fpm/entrypoint.sh | 12 ++++++++---- 31/apache/entrypoint.sh | 12 ++++++++---- 31/fpm-alpine/entrypoint.sh | 12 ++++++++---- 31/fpm/entrypoint.sh | 12 ++++++++---- docker-entrypoint.sh | 12 ++++++++---- 10 files changed, 80 insertions(+), 40 deletions(-) diff --git a/29/apache/entrypoint.sh b/29/apache/entrypoint.sh index 3bb57f1f..9fb5c971 100755 --- a/29/apache/entrypoint.sh +++ b/29/apache/entrypoint.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash set -eu # version_greater A B returns whether A > B @@ -67,8 +67,10 @@ file_env() { local var="$1" local fileVar="${var}_FILE" local def="${2:-}" - local varValue=$(env | grep -E "^${var}=" | sed -E -e "s/^${var}=//") - local fileVarValue=$(env | grep -E "^${fileVar}=" | sed -E -e "s/^${fileVar}=//") + local varValue + local fileVarValue + varValue=$(env | grep -E "^${var}=" | sed -E -e "s/^${var}=//") + fileVarValue=$(env | grep -E "^${fileVar}=" | sed -E -e "s/^${fileVar}=//") if [ -n "${varValue}" ] && [ -n "${fileVarValue}" ]; then echo >&2 "error: both $var and $fileVar are set (but are exclusive)" exit 1 @@ -80,7 +82,6 @@ file_env() { elif [ -n "${def}" ]; then export "$var"="$def" fi - unset "$fileVar" } if expr "$1" : "apache" 1>/dev/null; then @@ -186,12 +187,15 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP rsync_options="-rlD" fi + # shellcheck disable=SC2086 rsync $rsync_options --delete --exclude-from=/upgrade.exclude /usr/src/nextcloud/ /var/www/html/ for dir in config data custom_apps themes; do if [ ! -d "/var/www/html/$dir" ] || directory_empty "/var/www/html/$dir"; then + # shellcheck disable=SC2086 rsync $rsync_options --include "/$dir/" --exclude '/*' /usr/src/nextcloud/ /var/www/html/ fi done + # shellcheck disable=SC2086 rsync $rsync_options --include '/version.php' --exclude '/*' /usr/src/nextcloud/ /var/www/html/ # Install diff --git a/29/fpm-alpine/entrypoint.sh b/29/fpm-alpine/entrypoint.sh index 3bb57f1f..9fb5c971 100755 --- a/29/fpm-alpine/entrypoint.sh +++ b/29/fpm-alpine/entrypoint.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash set -eu # version_greater A B returns whether A > B @@ -67,8 +67,10 @@ file_env() { local var="$1" local fileVar="${var}_FILE" local def="${2:-}" - local varValue=$(env | grep -E "^${var}=" | sed -E -e "s/^${var}=//") - local fileVarValue=$(env | grep -E "^${fileVar}=" | sed -E -e "s/^${fileVar}=//") + local varValue + local fileVarValue + varValue=$(env | grep -E "^${var}=" | sed -E -e "s/^${var}=//") + fileVarValue=$(env | grep -E "^${fileVar}=" | sed -E -e "s/^${fileVar}=//") if [ -n "${varValue}" ] && [ -n "${fileVarValue}" ]; then echo >&2 "error: both $var and $fileVar are set (but are exclusive)" exit 1 @@ -80,7 +82,6 @@ file_env() { elif [ -n "${def}" ]; then export "$var"="$def" fi - unset "$fileVar" } if expr "$1" : "apache" 1>/dev/null; then @@ -186,12 +187,15 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP rsync_options="-rlD" fi + # shellcheck disable=SC2086 rsync $rsync_options --delete --exclude-from=/upgrade.exclude /usr/src/nextcloud/ /var/www/html/ for dir in config data custom_apps themes; do if [ ! -d "/var/www/html/$dir" ] || directory_empty "/var/www/html/$dir"; then + # shellcheck disable=SC2086 rsync $rsync_options --include "/$dir/" --exclude '/*' /usr/src/nextcloud/ /var/www/html/ fi done + # shellcheck disable=SC2086 rsync $rsync_options --include '/version.php' --exclude '/*' /usr/src/nextcloud/ /var/www/html/ # Install diff --git a/29/fpm/entrypoint.sh b/29/fpm/entrypoint.sh index 3bb57f1f..9fb5c971 100755 --- a/29/fpm/entrypoint.sh +++ b/29/fpm/entrypoint.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash set -eu # version_greater A B returns whether A > B @@ -67,8 +67,10 @@ file_env() { local var="$1" local fileVar="${var}_FILE" local def="${2:-}" - local varValue=$(env | grep -E "^${var}=" | sed -E -e "s/^${var}=//") - local fileVarValue=$(env | grep -E "^${fileVar}=" | sed -E -e "s/^${fileVar}=//") + local varValue + local fileVarValue + varValue=$(env | grep -E "^${var}=" | sed -E -e "s/^${var}=//") + fileVarValue=$(env | grep -E "^${fileVar}=" | sed -E -e "s/^${fileVar}=//") if [ -n "${varValue}" ] && [ -n "${fileVarValue}" ]; then echo >&2 "error: both $var and $fileVar are set (but are exclusive)" exit 1 @@ -80,7 +82,6 @@ file_env() { elif [ -n "${def}" ]; then export "$var"="$def" fi - unset "$fileVar" } if expr "$1" : "apache" 1>/dev/null; then @@ -186,12 +187,15 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP rsync_options="-rlD" fi + # shellcheck disable=SC2086 rsync $rsync_options --delete --exclude-from=/upgrade.exclude /usr/src/nextcloud/ /var/www/html/ for dir in config data custom_apps themes; do if [ ! -d "/var/www/html/$dir" ] || directory_empty "/var/www/html/$dir"; then + # shellcheck disable=SC2086 rsync $rsync_options --include "/$dir/" --exclude '/*' /usr/src/nextcloud/ /var/www/html/ fi done + # shellcheck disable=SC2086 rsync $rsync_options --include '/version.php' --exclude '/*' /usr/src/nextcloud/ /var/www/html/ # Install diff --git a/30/apache/entrypoint.sh b/30/apache/entrypoint.sh index 3bb57f1f..9fb5c971 100755 --- a/30/apache/entrypoint.sh +++ b/30/apache/entrypoint.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash set -eu # version_greater A B returns whether A > B @@ -67,8 +67,10 @@ file_env() { local var="$1" local fileVar="${var}_FILE" local def="${2:-}" - local varValue=$(env | grep -E "^${var}=" | sed -E -e "s/^${var}=//") - local fileVarValue=$(env | grep -E "^${fileVar}=" | sed -E -e "s/^${fileVar}=//") + local varValue + local fileVarValue + varValue=$(env | grep -E "^${var}=" | sed -E -e "s/^${var}=//") + fileVarValue=$(env | grep -E "^${fileVar}=" | sed -E -e "s/^${fileVar}=//") if [ -n "${varValue}" ] && [ -n "${fileVarValue}" ]; then echo >&2 "error: both $var and $fileVar are set (but are exclusive)" exit 1 @@ -80,7 +82,6 @@ file_env() { elif [ -n "${def}" ]; then export "$var"="$def" fi - unset "$fileVar" } if expr "$1" : "apache" 1>/dev/null; then @@ -186,12 +187,15 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP rsync_options="-rlD" fi + # shellcheck disable=SC2086 rsync $rsync_options --delete --exclude-from=/upgrade.exclude /usr/src/nextcloud/ /var/www/html/ for dir in config data custom_apps themes; do if [ ! -d "/var/www/html/$dir" ] || directory_empty "/var/www/html/$dir"; then + # shellcheck disable=SC2086 rsync $rsync_options --include "/$dir/" --exclude '/*' /usr/src/nextcloud/ /var/www/html/ fi done + # shellcheck disable=SC2086 rsync $rsync_options --include '/version.php' --exclude '/*' /usr/src/nextcloud/ /var/www/html/ # Install diff --git a/30/fpm-alpine/entrypoint.sh b/30/fpm-alpine/entrypoint.sh index 3bb57f1f..9fb5c971 100755 --- a/30/fpm-alpine/entrypoint.sh +++ b/30/fpm-alpine/entrypoint.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash set -eu # version_greater A B returns whether A > B @@ -67,8 +67,10 @@ file_env() { local var="$1" local fileVar="${var}_FILE" local def="${2:-}" - local varValue=$(env | grep -E "^${var}=" | sed -E -e "s/^${var}=//") - local fileVarValue=$(env | grep -E "^${fileVar}=" | sed -E -e "s/^${fileVar}=//") + local varValue + local fileVarValue + varValue=$(env | grep -E "^${var}=" | sed -E -e "s/^${var}=//") + fileVarValue=$(env | grep -E "^${fileVar}=" | sed -E -e "s/^${fileVar}=//") if [ -n "${varValue}" ] && [ -n "${fileVarValue}" ]; then echo >&2 "error: both $var and $fileVar are set (but are exclusive)" exit 1 @@ -80,7 +82,6 @@ file_env() { elif [ -n "${def}" ]; then export "$var"="$def" fi - unset "$fileVar" } if expr "$1" : "apache" 1>/dev/null; then @@ -186,12 +187,15 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP rsync_options="-rlD" fi + # shellcheck disable=SC2086 rsync $rsync_options --delete --exclude-from=/upgrade.exclude /usr/src/nextcloud/ /var/www/html/ for dir in config data custom_apps themes; do if [ ! -d "/var/www/html/$dir" ] || directory_empty "/var/www/html/$dir"; then + # shellcheck disable=SC2086 rsync $rsync_options --include "/$dir/" --exclude '/*' /usr/src/nextcloud/ /var/www/html/ fi done + # shellcheck disable=SC2086 rsync $rsync_options --include '/version.php' --exclude '/*' /usr/src/nextcloud/ /var/www/html/ # Install diff --git a/30/fpm/entrypoint.sh b/30/fpm/entrypoint.sh index 3bb57f1f..9fb5c971 100755 --- a/30/fpm/entrypoint.sh +++ b/30/fpm/entrypoint.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash set -eu # version_greater A B returns whether A > B @@ -67,8 +67,10 @@ file_env() { local var="$1" local fileVar="${var}_FILE" local def="${2:-}" - local varValue=$(env | grep -E "^${var}=" | sed -E -e "s/^${var}=//") - local fileVarValue=$(env | grep -E "^${fileVar}=" | sed -E -e "s/^${fileVar}=//") + local varValue + local fileVarValue + varValue=$(env | grep -E "^${var}=" | sed -E -e "s/^${var}=//") + fileVarValue=$(env | grep -E "^${fileVar}=" | sed -E -e "s/^${fileVar}=//") if [ -n "${varValue}" ] && [ -n "${fileVarValue}" ]; then echo >&2 "error: both $var and $fileVar are set (but are exclusive)" exit 1 @@ -80,7 +82,6 @@ file_env() { elif [ -n "${def}" ]; then export "$var"="$def" fi - unset "$fileVar" } if expr "$1" : "apache" 1>/dev/null; then @@ -186,12 +187,15 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP rsync_options="-rlD" fi + # shellcheck disable=SC2086 rsync $rsync_options --delete --exclude-from=/upgrade.exclude /usr/src/nextcloud/ /var/www/html/ for dir in config data custom_apps themes; do if [ ! -d "/var/www/html/$dir" ] || directory_empty "/var/www/html/$dir"; then + # shellcheck disable=SC2086 rsync $rsync_options --include "/$dir/" --exclude '/*' /usr/src/nextcloud/ /var/www/html/ fi done + # shellcheck disable=SC2086 rsync $rsync_options --include '/version.php' --exclude '/*' /usr/src/nextcloud/ /var/www/html/ # Install diff --git a/31/apache/entrypoint.sh b/31/apache/entrypoint.sh index 3bb57f1f..9fb5c971 100755 --- a/31/apache/entrypoint.sh +++ b/31/apache/entrypoint.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash set -eu # version_greater A B returns whether A > B @@ -67,8 +67,10 @@ file_env() { local var="$1" local fileVar="${var}_FILE" local def="${2:-}" - local varValue=$(env | grep -E "^${var}=" | sed -E -e "s/^${var}=//") - local fileVarValue=$(env | grep -E "^${fileVar}=" | sed -E -e "s/^${fileVar}=//") + local varValue + local fileVarValue + varValue=$(env | grep -E "^${var}=" | sed -E -e "s/^${var}=//") + fileVarValue=$(env | grep -E "^${fileVar}=" | sed -E -e "s/^${fileVar}=//") if [ -n "${varValue}" ] && [ -n "${fileVarValue}" ]; then echo >&2 "error: both $var and $fileVar are set (but are exclusive)" exit 1 @@ -80,7 +82,6 @@ file_env() { elif [ -n "${def}" ]; then export "$var"="$def" fi - unset "$fileVar" } if expr "$1" : "apache" 1>/dev/null; then @@ -186,12 +187,15 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP rsync_options="-rlD" fi + # shellcheck disable=SC2086 rsync $rsync_options --delete --exclude-from=/upgrade.exclude /usr/src/nextcloud/ /var/www/html/ for dir in config data custom_apps themes; do if [ ! -d "/var/www/html/$dir" ] || directory_empty "/var/www/html/$dir"; then + # shellcheck disable=SC2086 rsync $rsync_options --include "/$dir/" --exclude '/*' /usr/src/nextcloud/ /var/www/html/ fi done + # shellcheck disable=SC2086 rsync $rsync_options --include '/version.php' --exclude '/*' /usr/src/nextcloud/ /var/www/html/ # Install diff --git a/31/fpm-alpine/entrypoint.sh b/31/fpm-alpine/entrypoint.sh index 3bb57f1f..9fb5c971 100755 --- a/31/fpm-alpine/entrypoint.sh +++ b/31/fpm-alpine/entrypoint.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash set -eu # version_greater A B returns whether A > B @@ -67,8 +67,10 @@ file_env() { local var="$1" local fileVar="${var}_FILE" local def="${2:-}" - local varValue=$(env | grep -E "^${var}=" | sed -E -e "s/^${var}=//") - local fileVarValue=$(env | grep -E "^${fileVar}=" | sed -E -e "s/^${fileVar}=//") + local varValue + local fileVarValue + varValue=$(env | grep -E "^${var}=" | sed -E -e "s/^${var}=//") + fileVarValue=$(env | grep -E "^${fileVar}=" | sed -E -e "s/^${fileVar}=//") if [ -n "${varValue}" ] && [ -n "${fileVarValue}" ]; then echo >&2 "error: both $var and $fileVar are set (but are exclusive)" exit 1 @@ -80,7 +82,6 @@ file_env() { elif [ -n "${def}" ]; then export "$var"="$def" fi - unset "$fileVar" } if expr "$1" : "apache" 1>/dev/null; then @@ -186,12 +187,15 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP rsync_options="-rlD" fi + # shellcheck disable=SC2086 rsync $rsync_options --delete --exclude-from=/upgrade.exclude /usr/src/nextcloud/ /var/www/html/ for dir in config data custom_apps themes; do if [ ! -d "/var/www/html/$dir" ] || directory_empty "/var/www/html/$dir"; then + # shellcheck disable=SC2086 rsync $rsync_options --include "/$dir/" --exclude '/*' /usr/src/nextcloud/ /var/www/html/ fi done + # shellcheck disable=SC2086 rsync $rsync_options --include '/version.php' --exclude '/*' /usr/src/nextcloud/ /var/www/html/ # Install diff --git a/31/fpm/entrypoint.sh b/31/fpm/entrypoint.sh index 3bb57f1f..9fb5c971 100755 --- a/31/fpm/entrypoint.sh +++ b/31/fpm/entrypoint.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash set -eu # version_greater A B returns whether A > B @@ -67,8 +67,10 @@ file_env() { local var="$1" local fileVar="${var}_FILE" local def="${2:-}" - local varValue=$(env | grep -E "^${var}=" | sed -E -e "s/^${var}=//") - local fileVarValue=$(env | grep -E "^${fileVar}=" | sed -E -e "s/^${fileVar}=//") + local varValue + local fileVarValue + varValue=$(env | grep -E "^${var}=" | sed -E -e "s/^${var}=//") + fileVarValue=$(env | grep -E "^${fileVar}=" | sed -E -e "s/^${fileVar}=//") if [ -n "${varValue}" ] && [ -n "${fileVarValue}" ]; then echo >&2 "error: both $var and $fileVar are set (but are exclusive)" exit 1 @@ -80,7 +82,6 @@ file_env() { elif [ -n "${def}" ]; then export "$var"="$def" fi - unset "$fileVar" } if expr "$1" : "apache" 1>/dev/null; then @@ -186,12 +187,15 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP rsync_options="-rlD" fi + # shellcheck disable=SC2086 rsync $rsync_options --delete --exclude-from=/upgrade.exclude /usr/src/nextcloud/ /var/www/html/ for dir in config data custom_apps themes; do if [ ! -d "/var/www/html/$dir" ] || directory_empty "/var/www/html/$dir"; then + # shellcheck disable=SC2086 rsync $rsync_options --include "/$dir/" --exclude '/*' /usr/src/nextcloud/ /var/www/html/ fi done + # shellcheck disable=SC2086 rsync $rsync_options --include '/version.php' --exclude '/*' /usr/src/nextcloud/ /var/www/html/ # Install diff --git a/docker-entrypoint.sh b/docker-entrypoint.sh index 3bb57f1f..9fb5c971 100755 --- a/docker-entrypoint.sh +++ b/docker-entrypoint.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash set -eu # version_greater A B returns whether A > B @@ -67,8 +67,10 @@ file_env() { local var="$1" local fileVar="${var}_FILE" local def="${2:-}" - local varValue=$(env | grep -E "^${var}=" | sed -E -e "s/^${var}=//") - local fileVarValue=$(env | grep -E "^${fileVar}=" | sed -E -e "s/^${fileVar}=//") + local varValue + local fileVarValue + varValue=$(env | grep -E "^${var}=" | sed -E -e "s/^${var}=//") + fileVarValue=$(env | grep -E "^${fileVar}=" | sed -E -e "s/^${fileVar}=//") if [ -n "${varValue}" ] && [ -n "${fileVarValue}" ]; then echo >&2 "error: both $var and $fileVar are set (but are exclusive)" exit 1 @@ -80,7 +82,6 @@ file_env() { elif [ -n "${def}" ]; then export "$var"="$def" fi - unset "$fileVar" } if expr "$1" : "apache" 1>/dev/null; then @@ -186,12 +187,15 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP rsync_options="-rlD" fi + # shellcheck disable=SC2086 rsync $rsync_options --delete --exclude-from=/upgrade.exclude /usr/src/nextcloud/ /var/www/html/ for dir in config data custom_apps themes; do if [ ! -d "/var/www/html/$dir" ] || directory_empty "/var/www/html/$dir"; then + # shellcheck disable=SC2086 rsync $rsync_options --include "/$dir/" --exclude '/*' /usr/src/nextcloud/ /var/www/html/ fi done + # shellcheck disable=SC2086 rsync $rsync_options --include '/version.php' --exclude '/*' /usr/src/nextcloud/ /var/www/html/ # Install From a7603b75be5b6c38a649b7561d33106a781371c7 Mon Sep 17 00:00:00 2001 From: Sebastian Neuser Date: Tue, 17 Jun 2025 14:22:40 +0200 Subject: [PATCH 3/3] impr(entrypoint): set -o pipefail Signed-off-by: Sebastian Neuser --- 29/apache/entrypoint.sh | 2 +- 29/fpm-alpine/entrypoint.sh | 2 +- 29/fpm/entrypoint.sh | 2 +- 30/apache/entrypoint.sh | 2 +- 30/fpm-alpine/entrypoint.sh | 2 +- 30/fpm/entrypoint.sh | 2 +- 31/apache/entrypoint.sh | 2 +- 31/fpm-alpine/entrypoint.sh | 2 +- 31/fpm/entrypoint.sh | 2 +- docker-entrypoint.sh | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-) diff --git a/29/apache/entrypoint.sh b/29/apache/entrypoint.sh index 9fb5c971..4939e3cc 100755 --- a/29/apache/entrypoint.sh +++ b/29/apache/entrypoint.sh @@ -1,5 +1,5 @@ #!/bin/bash -set -eu +set -euo pipefail # version_greater A B returns whether A > B version_greater() { diff --git a/29/fpm-alpine/entrypoint.sh b/29/fpm-alpine/entrypoint.sh index 9fb5c971..4939e3cc 100755 --- a/29/fpm-alpine/entrypoint.sh +++ b/29/fpm-alpine/entrypoint.sh @@ -1,5 +1,5 @@ #!/bin/bash -set -eu +set -euo pipefail # version_greater A B returns whether A > B version_greater() { diff --git a/29/fpm/entrypoint.sh b/29/fpm/entrypoint.sh index 9fb5c971..4939e3cc 100755 --- a/29/fpm/entrypoint.sh +++ b/29/fpm/entrypoint.sh @@ -1,5 +1,5 @@ #!/bin/bash -set -eu +set -euo pipefail # version_greater A B returns whether A > B version_greater() { diff --git a/30/apache/entrypoint.sh b/30/apache/entrypoint.sh index 9fb5c971..4939e3cc 100755 --- a/30/apache/entrypoint.sh +++ b/30/apache/entrypoint.sh @@ -1,5 +1,5 @@ #!/bin/bash -set -eu +set -euo pipefail # version_greater A B returns whether A > B version_greater() { diff --git a/30/fpm-alpine/entrypoint.sh b/30/fpm-alpine/entrypoint.sh index 9fb5c971..4939e3cc 100755 --- a/30/fpm-alpine/entrypoint.sh +++ b/30/fpm-alpine/entrypoint.sh @@ -1,5 +1,5 @@ #!/bin/bash -set -eu +set -euo pipefail # version_greater A B returns whether A > B version_greater() { diff --git a/30/fpm/entrypoint.sh b/30/fpm/entrypoint.sh index 9fb5c971..4939e3cc 100755 --- a/30/fpm/entrypoint.sh +++ b/30/fpm/entrypoint.sh @@ -1,5 +1,5 @@ #!/bin/bash -set -eu +set -euo pipefail # version_greater A B returns whether A > B version_greater() { diff --git a/31/apache/entrypoint.sh b/31/apache/entrypoint.sh index 9fb5c971..4939e3cc 100755 --- a/31/apache/entrypoint.sh +++ b/31/apache/entrypoint.sh @@ -1,5 +1,5 @@ #!/bin/bash -set -eu +set -euo pipefail # version_greater A B returns whether A > B version_greater() { diff --git a/31/fpm-alpine/entrypoint.sh b/31/fpm-alpine/entrypoint.sh index 9fb5c971..4939e3cc 100755 --- a/31/fpm-alpine/entrypoint.sh +++ b/31/fpm-alpine/entrypoint.sh @@ -1,5 +1,5 @@ #!/bin/bash -set -eu +set -euo pipefail # version_greater A B returns whether A > B version_greater() { diff --git a/31/fpm/entrypoint.sh b/31/fpm/entrypoint.sh index 9fb5c971..4939e3cc 100755 --- a/31/fpm/entrypoint.sh +++ b/31/fpm/entrypoint.sh @@ -1,5 +1,5 @@ #!/bin/bash -set -eu +set -euo pipefail # version_greater A B returns whether A > B version_greater() { diff --git a/docker-entrypoint.sh b/docker-entrypoint.sh index 9fb5c971..4939e3cc 100755 --- a/docker-entrypoint.sh +++ b/docker-entrypoint.sh @@ -1,5 +1,5 @@ #!/bin/bash -set -eu +set -euo pipefail # version_greater A B returns whether A > B version_greater() {